ua1zbe/meshcore-bot-firmware
1
0
Fork 0
mirror of https://github.com/Colorado-Mesh/meshcore-bot-firmware.git synced 2026-08-11 08:10:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

forge: add patch 8 — drop [MCBOT] advert suffix

Browse Source 
The auto-discovery of known bots via the suffix only fed DM suppression,
which is moot since DMs are encrypted to one recipient. Channel
coordination now lands via patch 7's request token mechanism, which
doesn't need the suffix. Removes the marker, writeBotAdvertName,
isBotAdvertName, autoLearnKnownBotAdvert, and getAdvertNodeName; reverts
all four advert sites to use _prefs.node_name directly. Removes the
test_bot_advert_marker host test. Manual 'bot known add' from CLI still
works for explicit DM suppression.
This commit is contained in:
cj-vana
2026-05-16 19:55:44 -06:00
parent c13e5474dd
commit 064904e596
10 changed files with 235 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/firmware_bot/test_firmware_bot.cpp
View File

@@ -566,22 +566,6 @@ static void test_ack_response_format() {
assert(strncmp(small, "ack @[bob]", 10) == 0);
}
static void test_bot_advert_marker() {
char out[32];
size_t written = 0;
assert(FirmwareBot::writeBotAdvertName("node", out, sizeof(out), &written) == BOT_WRITE_OK);
assert(strcmp(out, "node" BOT_ADVERT_MARKER) == 0);
assert(written == strlen(out));
assert(FirmwareBot::isBotAdvertName(out, strlen(out)));
assert(!FirmwareBot::isBotAdvertName("node", 4));
assert(!FirmwareBot::isBotAdvertName("node [bot]", 10));
char small[12];
assert(FirmwareBot::writeBotAdvertName("very-long-node-name", small, sizeof(small), &written) == BOT_WRITE_TRUNCATED);
assert(FirmwareBot::isBotAdvertName(small, strlen(small)));
assert(written == sizeof(small) - 1);
}
static BotMessage make_message(const char* channel, const char* text) {
BotMessage message;
memset(&message, 0, sizeof(message));
@@ -1661,7 +1645,6 @@ int main() {
test_response_write();
test_channel_text_and_response_guards();
test_ack_response_format();
test_bot_advert_marker();
test_command_outputs();
test_path_command();
test_trace_result_format();