From 2bb5b353bd2293942d07cd9fab311eb76678cfaf Mon Sep 17 00:00:00 2001
From: Janez T <hey@dz0ny.dev>
Date: Sun, 15 Mar 2026 21:00:02 +0100
Subject: [PATCH] Fix channel refresh telemetry how

---
 lib/providers/connection_provider.dart     |  4 +++
 lib/providers/contacts_provider.dart       |  2 +-
 test/providers/contacts_provider_test.dart | 32 ++++++++++++++--------
 3 files changed, 26 insertions(+), 12 deletions(-)

diff --git a/lib/providers/connection_provider.dart b/lib/providers/connection_provider.dart
index 4ff4bba..cb02ee2 100644
--- a/lib/providers/connection_provider.dart
+++ b/lib/providers/connection_provider.dart
@@ -1257,6 +1257,10 @@ class ConnectionProvider with ChangeNotifier {
         channelName: channelName,
         secret: secretBytes,
       );
+
+      // Reconcile local state from the device after the write completes,
+      // matching the delete flow so channel/contact lists refresh immediately.
+      await _activeService.getChannel(slotIdx);
     } catch (e) {
       if (_isChannelRefreshTimeoutError(e)) {
         debugPrint(
diff --git a/lib/providers/contacts_provider.dart b/lib/providers/contacts_provider.dart
index 9567bc0..7e3835b 100644
--- a/lib/providers/contacts_provider.dart
+++ b/lib/providers/contacts_provider.dart
@@ -875,7 +875,7 @@ class ContactsProvider with ChangeNotifier {
           telemetry.gpsLocation,
         )) {
           debugPrint(
-            '  ⚠️ Retaining last valid GPS. Incoming telemetry GPS is invalid/missing: $incomingGps',
+            '  ⚠️ Incoming telemetry GPS is invalid/missing; keeping last known contact location as fallback: $incomingGps',
           );
         }
         telemetry = ContactTelemetry(
diff --git a/test/providers/contacts_provider_test.dart b/test/providers/contacts_provider_test.dart
index 1544c36..16b0f15 100644
--- a/test/providers/contacts_provider_test.dart
+++ b/test/providers/contacts_provider_test.dart
@@ -137,7 +137,7 @@ void main() {
     });
 
     test(
-      'retains last valid gps for any contact when telemetry gps is invalid or missing',
+      'clears telemetry gps on refresh when gps is invalid or missing but keeps fallback display location',
       () {
         final contactTypes = <ContactType>[
           ContactType.chat,
@@ -165,23 +165,24 @@ void main() {
           );
           scopedProvider.updateTelemetry(scopedKey.sublist(0, 6), validGps);
 
-          // No GPS frame should keep previous valid GPS.
+          // No GPS frame should clear telemetry GPS but keep the last known
+          // contact location as display fallback.
           final batteryOnly = CayenneLppParser.createBatteryData(3.8);
           scopedProvider.updateTelemetry(scopedKey.sublist(0, 6), batteryOnly);
 
           var updated = scopedProvider.findContactByKey(scopedKey)!;
           expect(updated.telemetry, isNotNull);
-          expect(updated.telemetry!.gpsLocation, isNotNull);
+          expect(updated.telemetry!.gpsLocation, isNull);
           expect(
-            updated.telemetry!.gpsLocation!.latitude,
+            updated.displayLocation!.latitude,
             closeTo(45.1234, 0.0001),
           );
           expect(
-            updated.telemetry!.gpsLocation!.longitude,
+            updated.displayLocation!.longitude,
             closeTo(13.8765, 0.0001),
           );
 
-          // Invalid 0,0 GPS frame should also keep previous valid GPS.
+          // Invalid 0,0 GPS frame should behave the same way.
           final invalidGps = CayenneLppParser.createGpsData(
             latitude: 0.0,
             longitude: 0.0,
@@ -190,13 +191,13 @@ void main() {
 
           updated = scopedProvider.findContactByKey(scopedKey)!;
           expect(updated.telemetry, isNotNull);
-          expect(updated.telemetry!.gpsLocation, isNotNull);
+          expect(updated.telemetry!.gpsLocation, isNull);
           expect(
-            updated.telemetry!.gpsLocation!.latitude,
+            updated.displayLocation!.latitude,
             closeTo(45.1234, 0.0001),
           );
           expect(
-            updated.telemetry!.gpsLocation!.longitude,
+            updated.displayLocation!.longitude,
             closeTo(13.8765, 0.0001),
           );
         }
@@ -360,13 +361,22 @@ void main() {
 
       final updated = provider.findContactByKey(publicKey)!;
       expect(updated.telemetry, isNotNull);
-      expect(updated.telemetry!.gpsLocation, const LatLng(46.0569, 14.5058));
+      expect(updated.telemetry!.gpsLocation, isNull);
+      expect(updated.displayLocation, const LatLng(46.0569, 14.5058));
       expect(updated.telemetry!.batteryMilliVolts, isNotNull);
       expect(updated.telemetry!.batteryPercentage, isNotNull);
       expect(updated.telemetry!.temperature, equals(19.5));
       expect(updated.telemetry!.humidity, equals(58.0));
       expect(updated.telemetry!.pressure, equals(1011.2));
-      expect(updated.telemetry!.extraSensorData, isNull);
+      expect(
+        updated.telemetry!.extraSensorData,
+        containsPair('__source_channel:battery', 0),
+      );
+      expect(
+        updated.telemetry!.extraSensorData,
+        containsPair('__source_channel:voltage', 0),
+      );
+      expect(updated.telemetry!.extraSensorData, isNot(contains('pm25')));
     });
 
     test('replaces old source-channel mappings when a metric moves channels', () {