From 2e8f4ed6e00a7d07c877d67f133130e74f54b47b Mon Sep 17 00:00:00 2001 From: Janez T Date: Wed, 22 Oct 2025 12:21:11 +0200 Subject: [PATCH] fix: Correctly set BASE_URL for unstable build artifacts in GitHub Actions workflow --- .github/R2_SETUP.md | 2 +- .github/workflows/build-multiplatform.yml | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/R2_SETUP.md b/.github/R2_SETUP.md index 5093d49..8abd8c3 100644 --- a/.github/R2_SETUP.md +++ b/.github/R2_SETUP.md @@ -28,7 +28,7 @@ Configure these secrets in your GitHub repository settings (`Settings` → `Secr | Secret Name | Description | Example | |-------------|-------------|---------| -| `R2_PUBLIC_URL` | Public URL for R2 bucket (if public access configured) | `https://builds.example.com` | +| `R2_PUBLIC_URL` | Public URL for R2 bucket (if public access configured) | `https://meshcore-sar.dz0ny.dev` | ## Step-by-Step Setup diff --git a/.github/workflows/build-multiplatform.yml b/.github/workflows/build-multiplatform.yml index e9565ef..fb5952c 100644 --- a/.github/workflows/build-multiplatform.yml +++ b/.github/workflows/build-multiplatform.yml @@ -843,12 +843,14 @@ jobs: run: | # If R2_PUBLIC_URL is set, generate public download links if [ -n "${{ secrets.R2_PUBLIC_URL }}" ]; then + BASE_URL="${{ secrets.R2_PUBLIC_URL }}/unstable/${{ steps.metadata.outputs.build_prefix }}" + echo "## 📦 Unstable Build Artifacts" >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY echo "Build ID: \`${{ steps.metadata.outputs.build_prefix }}-${{ steps.metadata.outputs.timestamp }}\`" >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY - - BASE_URL="${{ secrets.R2_PUBLIC_URL }}/unstable/${{ steps.metadata.outputs.build_prefix }}" + echo "🌐 **[View Download Page]($BASE_URL/)**" >> $GITHUB_STEP_SUMMARY + echo "" >> $GITHUB_STEP_SUMMARY if [ -f "r2-upload/unstable/${{ steps.metadata.outputs.build_prefix }}"/*.apk ]; then APK_FILE=$(basename r2-upload/unstable/${{ steps.metadata.outputs.build_prefix }}/*.apk)